231772 - favicons do not display for some sites

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[John Griffiths]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040121 MultiZilla/1.6.1.0a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040121 MultiZilla/1.6.1.0a

I believe it may have to do with the size of the favicon.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040101
MultiZilla/1.6.1.0a did not exhibit this problem.

 After installing Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a)
Gecko/20040121 MultiZilla/1.6.1.0a, the favicons for some sites quit displaying
or would display on a reload but disappear again when traversing between tabs.

Reproducible: Always

Steps to Reproduce:
1. Only a couple of tabs on Mozilla
2. Load a site like www.foxnews.com in one tab.
3. Load a site like www.phpBB.com in another

Actual Results:  
After a refresh, the Fox News favicon is replaces by the default. A refresh of
the phpBB tab, the  favicon remains visible.

The all the favicons in the bookmarks are also replaced by the default.

Expected Results:  
Sites that have favicons should display correctly in the address window, the
tabs, and the bookmarks.

Comment 1

[HJ]

WFM on WinXP with mozilla build 2004012109. 

What if you disable MultiZilla in QPrefs/Extension Management? You can re-enable
MultiZila with 'chrome://multiviews/content/reEnableMultiZilla.xul'.

Comment 2

[John Griffiths]

Tried disabling Multizilla. Same result. 

To check whether it was in Mozilla or Multizill, I installed an older nightly of
Mozilla and installed the new Multizilla, Mozilla/5.0 (X11; U; Linux i686;
en-US; rv:1.7a) Gecko/20040101 MultiZilla/1.6.1.0a. This combination did not
have the problem with the favicons.

Comment 3

[HJ]

Recomment 2: Ok, just for the record.

CC'ing Neil.

Neil, maybe we missed something with the patch for bug 225854. You moved
DOMLinkAdded from mPanelContainer to tabbrowser and I wonder if that move is
causing this bug. What do you think?

Comment 4

[[e-mail]]

Attachment: Oops

Comment 5

[jag (Peter Annema)]

Comment on attachment 139705 [details] [diff] [review]
Oops

Heh, oops :-) r+sr=jag

Comment 6

[HJ]

Yeah that's it. Still, onLinkAdded() is triggered 7 or 8 times for each icon, a
bit to much if you ask me. Can we reduce this somehow?

Comment 7

[[e-mail]]

Not really, the other notifications are required by the link toolbar.

Comment 8

[John Griffiths]

The favicons still do not display correctly in the bookmarks. 

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040123 MultiZilla/1.6.1.0a

Comment 9

[[e-mail]]

Open about:config and search for browser.chrome.load_toolbar_icons
What value do you have?

Comment 10

[John Griffiths]

browser.chrome.load_toolbar_icons = 0

I tried 1 too, but the bookmark icons stay the default.

Comment 11

[[e-mail]]

The values mean:
0 - never show icons
1 - show icons that are in the cache
2 - always load missing icons

Comment 12

[John Griffiths]

Thanks. But I set the value to 2 and the favicons still do not display in the
bookmarks.

Are the possible values for each of the configuration items documented somewhere?

Comment 13

[John Griffiths]

Sorry I reopenned this bug. Duh. Forgot to restart Mozilla after changing values
of browser.chrome.load_toolbar_icons. Just thought the new value would work.
Should have realized these values are read on startup. Not one of my brighter
moments.