231835 - It's now "Bookmarks File" (plural), update help documentation

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

Bug 231738 is about to change "Bookmark File" to "Bookmarks File" (consistency,
4.x parity).
/extensions/help/resources/locale/en-US/customize_help.html and
/extensions/help/resources/locale/en-US/customize_help.xhtml (are they both
used??) does mostly use singular (though also using plural sometimes) and should
be updated.



Reproducible: Always

Steps to Reproduce:

Comment 1

[Joe Infla]

Attachment: find & replace plus one unrelated typo correction

This changes all "bookmark file" to "bookmarks file" and corrects an unrelated
typo found in the same file.  A further question about how much to change,
though:
Should the plurality change apply also to "Bookmark List" and "Bookmark
Folder?"

Comment 2

[Andreas Kunz]

I'm not sure if it should use the same capitalization... it's now "Bookmarks
File", uppercase... but that should be decided by help people. Just as if every
occurrance should be replaced...

Comment 3

[Joe Infla]

Attachment: v2 - use correct Title Caps as appropriate

changed to Title Caps when directly referencing the dialogs.

Comment 4

[Daniel Wang]

Comment on attachment 139695 [details] [diff] [review]
v2 - use correct Title Caps as appropriate

+Personal Toolbar Bookmark Folders</a>&quot; for more information on adding a
bookmark

"Personal Toolbar Bookmark Folders" is not right. It should be "Personal
Toolbar Folder". But that is another bug. Joe, want to tackle this in another
patch?

r=daniel

Comment 5

[Joe Infla]

(In reply to comment #4)
> "Personal Toolbar Bookmark Folders" is not right. It should be "Personal
> Toolbar Folder". 

The reference's is about adding folders to the "Personal Toolbar Folder."  So I
think the original motivation for the current, somewhat awkward, wording was to
avoid the more awkward wording "Personal Toolbar Folder folders."

Simply referring to folders within the PT as "Personal Toolbar folders" is also
potentially misleading since the most common exposure to the phrase is within
the bookmarks list as a prepopulated entry of the same form (referring instead
to the PT Folder).  I'd be happy to open a separate bug on it if you disagree,
though.

Meanwhile, should I also open a bug for changing the plurality of "Bookmark
List" and "Bookmark Folder" entries, as mentioned in comment 1?

Comment 6

[R.J. Keller]

Joe: I think what daniel is saying is that it should be rephrased. His example
was not correct, though. I personally would rather remove the bookmark and say
"Personal Toolbar Folders".

Comment 7

[Daniel Wang]

> I personally would rather remove the bookmark and say "Personal Toolbar
> Folders".

Mozilla can only have one Personal Toolbar Folder. I am not sure why the 's' was
there in the first place.

Comment 8

[Joe Infla]

Attachment: v3 - remove that unrelated change under discussion

this patch removes the change to that line under discussion, since it was the
"unrelated typo" anyway.  This should be fine to check in as-is, but I don't
have cvs access, so one of you will need to.

I created bug 232299 on the Personal Toolbar Bookmark Folders phrasing.

Comment 9

[R.J. Keller]

Fix checked in.

Comment 10

[Daniel Wang]

reopen. The wrong file is patched. We use customize_help.html in Help but the
patch is for customize_help.xhtml

Comment 11

[Joe Infla]

sorry, I was under the impression that one generated the other.  I'll post a new
patch in the daytime.  Could someone clarify for me what the xhtml file is used
for, and whether changes to one need to be duplicated for the other?

Comment 12

[Joe Infla]

Attachment: v4 patch .html instead of .xhtml

patch correct file.

Comment 13

[R.J. Keller]

Fix checked in.

Comment 14

[R.J. Keller]

Reopening bug. Drivers approval is required for checkin.

Comment 15

[chris hofmann]

Comment on attachment 140171 [details] [diff] [review]
v4 patch .html instead of .xhtml

a=chofmann

Comment 16

[Daniel Wang]

rlk, can you check in the patch?

Comment 17

[R.J. Keller]

Sorry, I checked in the patches for these bugs again and forgot to post a
comment ;). They've been in for awhile.

Comment 18

[Daniel Wang]

am I missing something?
I'm in 1.7 final and can still see this bug

Comment 19

[Andreas Kunz]

Right, lxr says, attachment 140171 [details] [diff] [review] (v4 patch) has not been checked in to trunk
(and therefore not to the 1.7 branch). That's the eight changes in
customize_help.html.

Comment 20

[Stefan [:stefanh]]

customize_help.html will be gone soon with the patch
(http://bugzilla.mozilla.org/attachment.cgi?id=151110&action=view) in bug 95770
(If I get "r" of course)

The problem is that the xhtml version is converted from the .html file. So in
the xhtml version you'll still see references to "Bookmark File". Can we leave
this bug open and update the patch after the file has been converted?

Comment 21

[Stefan [:stefanh]]

The patch in bug 249577 will fix this.

Comment 22

[Stefan [:stefanh]]

Fixed by the check-in of the patch in bug 249577.