231849 - [BEOS] Network optimizations from UNIX

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement)

Description

[tqh]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7a) Gecko/20040122 Firebird/0.8.0+
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7a) Gecko/20040122 Firebird/0.8.0+

As the BeOS under BONE network code is mostly identical to UNIX I moved over
some missing optimizations from there. Seems to work just fine.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[tqh]

Attachment: UNIX net-optimizations

These are the same to those on UNIX except we run under bthreads so we only
need native thread implementation.

Comment 2

[tqh]

Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

review request

Comment 3

[tqh]

CC'ing sergei_d

Comment 4

[Darin Fisher]

Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

please don't use the word "Stolen" in code... it gets some people overly
excited ;-)

nit: your indentation is inconsistent.	there is a mix of tabs and spaces used
for indentation.

Comment 5

[Wan-Teh Chang]

Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

1. Remove the "Stolen from ../unix/unix.c" comments.

2. Format the code in the prevalent indentation style
of bnet.c.

Comment 6

[tqh]

Attachment: Cleaned up patch

Ok, this one should be cleaner.

(Thanks for reviewing this, I'm not sure who to turn to about BeOS specific
nspr-patches.)

Comment 7

[tqh]

Comment on attachment 140251 [details] [diff] [review]
Cleaned up patch

requesting sr

(and hoping for someone with cvs-access to commit it if passed)

Comment 8

[Wan-Teh Chang]

Comment on attachment 140251 [details] [diff] [review]
Cleaned up patch

r=wtc.

Comment 9

[Darin Fisher]

patch landed on NSPRPUB_PRE_4_2_CLIENT_BRANCH for 1.7 beta.  leaving open for
wtc to land patch on NSPR trunk.

Comment 10

[Wan-Teh Chang]

Patch checked in on the NSPR trunk for NSPR 4.5.