Closed
Bug 231983
Opened 21 years ago
Closed 21 years ago
xpicleanup incorrectly uses strcmp
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Core Graveyard
Installer: XPInstall Engine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pkwarren, Assigned: pkwarren)
Details
Attachments
(1 file)
|
652 bytes,
patch
|
timeless
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
In InstallCleanupUNIX.cpp, there is the following snippet of code:
74 // don't have to do anything if the files are the same
75 if (strcmp(replacementFile, doomedFile))
76 return DONE;
77
This should be:
if (strcmp(replacementFile, doomedFile) == 0)
|
Assignee | |
Comment 1•21 years ago
|
||
Assignee: xpi-engine → pkw
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 years ago
|
Attachment #141331 -
Flags: superreview?(mkaply)
Attachment #141331 -
Flags: review?(timeless)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 141331 [details] [diff] [review]
Patch
sr=darin
Attachment #141331 -
Flags: superreview?(mkaply) → superreview+
Attachment #141331 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•