Closed
Bug 231996
Opened 22 years ago
Closed 22 years ago
[BEOS]Improper background clipping
Categories
(Core Graveyard :: GFX: BeOS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sergei_d, Assigned: sergei_d)
Details
Attachments
(1 file)
|
5.58 KB,
patch
|
sergei_d
:
review+
|
Details | Diff | Splinter Review |
on some sites like http://www.opera.com
bacground rectangles are drawn outside proper areas.
Reason - current nsImageBeOS::DrawTile() implementation don't use undocumented
parameters (sXOffset and sYOffset).
Fix will be submitted soon.
|
Assignee | |
Updated•22 years ago
|
Assignee: beos → sergei_d
Summary: [BEOS]Improper background clippin → [BEOS]Improper background clipping
Created patch
Fixes rendering, using aSXOffset and aSYOffset parameters.
Also fixes bug where the last line of the tile bitmap was not copied.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Simon, i think there was my mistake when i provided you with new code with
tmpbmp filling with transparent color in addition to your offset fixes...
for (int32 x = 0; x < rowscan.quot; ++x) - ??? shoild it be there???
|
|
Assignee | |
Comment 3•22 years ago
|
||
Simon,
in previous comment i meant that place
if (0 != mAlphaDepth || padding)
{
for (int32 x = 0; x < rowscan.quot; ++x)
//Prefilll first scanline
Are you able to do new patch yourself?
All other seems ok.
|
|
Assignee | |
Comment 4•22 years ago
|
||
Comment on attachment 139792 [details] [diff] [review]
Fixes DrawTile rendering errors
Simmon, sorry. Didn't notice "-" in that place.
so, r=sergei_d@fi.tartu.ee
Attachment #139792 -
Flags: review+
|
|
Assignee | |
Comment 5•22 years ago
|
||
checkin by bsmedberg.
Marking fixed
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•