232129 - imap protocol logging doesn't handle long lines

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

because nspr logging limits line length to 512 bytes, IMAP protocol logging
misses out on some data, especially when doing an APPEND. Since we're having
trouble with fcc not completing on some servers for some users, it would be very
useful to see the whole data sent.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this takes logData longer than 400 bytes and breaks it into 400 byte chunks,
and prints out all the data. This solution isn't perfect, because the pr log
dumps an extra CR every 400 bytes. The data passed in is const so we can't muck
with it in place. I suppose we could make a copy of it and then log it on a
per-line basis. Maybe I'll play with that, since the line endings could turn
out to be significant.

Comment 2

[David :Bienvenu]

Attachment: fix that doesn't add newlines

This patch doesn't add extra newlines, and handles lines > 400 bytes (though
that does cause prlogging to add an extra newline, but we shouldn't be sending
lines > 400 bytes.

Comment 3

[Scott MacGregor]

David, is there anyway to only execute this new code if logging is turned on?

Comment 4

[David :Bienvenu]

It is only executed if logging is turned on - you can't see this from the diff,
but it's all inside 

if (PR_LOG_TEST(IMAP, PR_LOG_ALWAYS))
{
...
}

In my tree, I've changed the initial strlen to PL_strlen because PL_strlen
checks for null, and logData can be null.

Comment 5

[Scott MacGregor]

Comment on attachment 139853 [details] [diff] [review]
fix that doesn't add newlines

cool. thanks for the clarification.

Comment 6

[David :Bienvenu]

fix checked in.