232132 - [FIXr]XBL property compilation should really not need to copy the method bodies

Status: RESOLVED FIXED

(Core :: XBL, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Method compilation uses dependent strings and just doesn't assign directly into
the union.  Property compilation should behave similarly.

timeless, if you get a chance to work on this, that would be great; otherwise
I'll do it sometime....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140788 [details] [diff] [review]
Same as diff -w

timeless, bryner, could you review?  The basic idea is to compile into a
temporary and then delete the text member before assigning into the union.

The rest is just combining some common code into the superclass.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Need this too (makefile change)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140788 [details] [diff] [review]
Same as diff -w

Note: I used MPL for the new file, since this is just a bit-for-bit copy of
some existing MPL code (and I left hyatt as the original author for the same
reason).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, "I used NPL".  ;)

Comment 7

[timeless]

Comment on attachment 140788 [details] [diff] [review]
Same as diff -w

The refcounting for error cases in nsXBLProtoImplMember::AddJSGCRoot /
nsXBLProtoImplMember::RemoveJSGCRoot is faulty (leaky iirc) and could be fixed. 

(this isn't a blocker as the handling not changed by this patch)

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.7b