232133 - nsHTMLSelectElement cleanup and deCOMtamination

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

Found silly stuff while browsing code, patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139851 [details] [diff] [review]
Fix

>Index: content/html/content/src/nsHTMLSelectElement.cpp

> nsHTMLOptionCollection::SetOption(PRInt32 aIndex,

>+  if (mSelect && (aIndex >= 0) && (aIndex <= (PRInt32)mElements.Count())) {

No need for that cast (or the extra parens, for that matter).

> nsHTMLOptionCollection::NamedItem(const nsAString& aName,

>+  PRUint32 count = mElements.Count();

PRInt32

>   for (PRUint32 i = 0; i < count && !*aReturn; i++) {

Same.

>+        break;

Given that, do you need the !*aReturn test in the for?	I doubt it, and this
seems right -- we shouldn't be ending up with nsIContent in there that has a
name or id attr but doesn't QI to nsIDOMNode...

r+sr=bzbarsky with those nits.

Comment 3

[Johnny Stenback (:jst)]

Fixed. Thanks for the review!