232175 - Refactor nsNativeThemeWin

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Isaac Hwak Han]

From bug 181490:
Make nsNativeThemeWin inherit from nsNativeTheme to remove some duplicated code.

Comment 1

[Isaac Hwak Han]

Attachment: Patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Isaac, is that patch ready to go?  That is, is it at the point where it needs
reviews?

Comment 3

[Isaac Hwak Han]

Attachment: Patch (up to the trunk)

Since the patch in bug 181490 has been checked-in, I'm uploading a new patch.

Comment 4

[Isaac Hwak Han]

Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

Requesting r/sr.

This patch is just a code cleanup -- eliminating a few obvious duplicate member
variables and functions of nsNativeTheme and nsNativeThemeWin.

Changes in nsNativeTheme::IsWidgetStyle() is from bug 181490, but here, mac is
also affected.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I won't be able to get to the review till I come back from my trip at this
point... (a week and a half from now at least).

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

Looks good.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 144110 [details] [diff] [review]
Patch (up to the trunk)

sr=bzbarsky.

Please ping me when 1.8 opens (or once this has approval if you go for 1.7) and
I'll check it in, ok?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Patch checked in to 1.8a trunk.