Closed Bug 232281 Opened 21 years ago Closed 20 years ago

outerHTML property in MsHtml.IHtmlElement is not implemented

Categories

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

x86
Windows 2000
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: atremon, Assigned: adamlock)

Details

Attachments

(2 files, 1 obsolete file)

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

put_outerHTML and get_outerHTML are not implemented in CIEHtmlElement class

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
dupe of bug 92264?
Status: UNCONFIRMED → NEW
Ever confirmed: true
bug 92264 is about the mozilla dom.
This is about the Mozilla Control which is intended to replace the IE activeX.

Attachment #139970 - Attachment is obsolete: true
Comment on attachment 139972 [details] [diff] [review]
previous attachment was not a diff

r=adamlock

Looks great to me
Attachment #139972 - Flags: review+
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 139972 [details] [diff] [review]
previous attachment was not a diff

 HRESULT STDMETHODCALLTYPE CIEHtmlElement::put_outerHTML(BSTR v)
 {
-    return E_NOTIMPL;
+	nsresult rv;
+	nsCOMPtr<nsIDOMDocument> domDoc;
...

This new code uses tabs for indentation, don't. Follow what's used in the rest
of the file.

 HRESULT STDMETHODCALLTYPE CIEHtmlElement::get_outerHTML(BSTR __RPC_FAR *p)
 {
...
+    }
+
+    *p = NULL;
+
+	nsresult rv;
+	nsAutoString outerHTML;

Mixed indentation, stick with spaces, don't use tabs.

sr=jst with the indentation fixed.
Attachment #139972 - Flags: superreview?(jst) → superreview+
Fix is checked in, thanks Alexandre!
Status: REOPENED → RESOLVED
Closed: 21 years ago20 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: