232339 - incorrect string usage

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Most of the things shown in these LXR queries are examples of incorrect string
usage:

http://lxr.mozilla.org/seamonkey/search?string=%3D+NS_Convert.*get%5C%28%5C%29
http://lxr.mozilla.org/seamonkey/search?string=%3D+PromiseFlat.*get%5C%28%5C%29

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

some of these are real fixes, some are just slight performance improvements to
avoid the LXR hits

Comment 2

[Boris Zbarsky [:bzbarsky]]

> +                profileItem->profileName =
NS_ConvertASCIItoUCS2(unixProfileName);

Wouldn't CopyASCIItoUTF16 or whatever we call it nowadays work better here?

Comment 3

[Jungshik Shin]

(In reply to comment #2)
> > +                profileItem->profileName =
> NS_ConvertASCIItoUCS2(unixProfileName);
> 
> Wouldn't CopyASCIItoUTF16 or whatever we call it nowadays work better here?

Yes. There are a couple of more like that in the patch. 

Comment 4

[Darin Fisher]

>+  const nsPromiseFlatCString& FFREName = PromiseFlatCString(aFFREName);

looks familiar! ;-)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 6

[Jungshik Shin]

Comment on attachment 140458 [details] [diff] [review]
patch

r=jshin

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-02-03 10:23 -0800.