232393 - misc views cleanup

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Over the past year or so I've accumulated some minor cleanup in the view/
directory of my tree.  I'm not much attached to any of it (especially the stuff
in nsView::List).  However, I'd rather get it out of my tree in one way or
another, and I think at least some of it is worth checking in.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This contains:
 * printing some additional information I cared about once in nsView::List
(this could easily go if you'd prefer it not checked in
 * make IsZPlaceholderView |const|
 * clean up nsView::Release -- the macro implementation has done refcount
stabilization for years; move the extra code into the destructor
 * Remove unused parameter from CreateDisplayList
 * a bunch of other really obvious things (except that I don't remember why I
wrote the "XXXldb lying" comment)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 140051 [details] [diff] [review]
patch

roc, I was hoping you could give me a check-in vs. throw-out opinion on this. 
(I was hoping to get it out of my tree to hack on bug 20022.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Actually, I want to remove nsView::HandleEvent too, which just forwards to
nsViewManager::HandleEvent, so hold on before reviewing.)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

look at this patch instead

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 140052 [details] [diff] [review]
patch

looks fine. We got rid of the last overrider of HandleEvent when we got rid of
native scrollbars.

BTW will you review the rest of my view cleanup patch or are you waiting on me
for something?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2004-01-28 16:04 -0800.