Closed Bug 232399 Opened 22 years ago Closed 21 years ago

dragging links to the bookmarks button should open the "Add Bookmark" dialog

Categories

(Firefox :: Toolbars and Customization, enhancement, P3)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.0beta

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file, 3 obsolete files)

unbitrotted again (browser/locales)
3.52 KB, patch
mconnor
: review+
steffen.wilberg
: approval-aviary+
Details | Diff | Splinter Review
Dragging links to the bookmarks button should open the "Add Bookmark" dialog. Dragging to the home button (set homepage) and downloads button (download that) already work.
Attached patch patch (obsolete) — — Splinter Review
Assignee: hyatt → steffen.wilberg
Status: NEW → ASSIGNED
Comment on attachment 140113 [details] [diff] [review] patch Pierre, I don't know if every single bit is right here, but it works fine. Please have a look.
Attachment #140113 - Flags: review?(p_ch)
Comment on attachment 140113 [details] [diff] [review] patch Oops, I cleaned up too much...
Attachment #140113 - Attachment is obsolete: true
Attachment #140113 - Flags: review?(p_ch)
Attached patch patch v1.1 (obsolete) — — Splinter Review
Attachment #140144 - Flags: review?(p_ch)
Attached patch unbitrotted (obsolete) — — Splinter Review
Attachment #140144 - Attachment is obsolete: true
Attachment #140144 - Flags: review?(p_ch)
Comment on attachment 144104 [details] [diff] [review] unbitrotted Hello Pierre, is anybody there? :)
Attachment #144104 - Flags: review?(p_ch)
Comment on attachment 144104 [details] [diff] [review] unbitrotted This is for consistency with the homme and the downloads button.
Attachment #144104 - Flags: review?(p_ch) → review?(bugs)
Target Milestone: --- → Firefox0.9
Same as before.
Attachment #144104 - Attachment is obsolete: true
Attachment #144104 - Flags: review?(bugs)
Comment on attachment 152729 [details] [diff] [review] unbitrotted again (browser/locales) This is for consistency with the home, downloads and go buttons.
Attachment #152729 - Flags: review?(bugs)
Requesting blocking RC1 due to localization impact.
Flags: blocking-aviary1.0RC1?
Not blocking rc1, but if you can get it checked in by rc1, great.
Flags: blocking-aviary1.0RC1? → blocking-aviary1.0RC1-
Comment on attachment 152729 [details] [diff] [review] unbitrotted again (browser/locales) Blake, you said you like this. I can certainly check it in if someone reviews it :)
Attachment #152729 - Flags: review?(bugs) → review?(firefox)
Attachment #152729 - Flags: approval-aviary?
Comment on attachment 152729 [details] [diff] [review] unbitrotted again (browser/locales) Please don't request approval until you've received necessary reviews. Thanks.
Attachment #152729 - Flags: approval-aviary?
Whiteboard: [have patch]
Priority: -- → P3
Target Milestone: Firefox0.9 → Firefox1.0beta
Comment on attachment 152729 [details] [diff] [review] unbitrotted again (browser/locales) Yeah, let's try to get this in.
Attachment #152729 - Flags: review?(firefox)
Attachment #152729 - Flags: review+
Attachment #152729 - Flags: approval-aviary?
Comment on attachment 152729 [details] [diff] [review] unbitrotted again (browser/locales) I think comment 11 means a=blake :)
Attachment #152729 - Flags: approval-aviary? → approval-aviary+
Checked in br & trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: [have patch]
QA Contact: bugzilla → toolbars
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: