232431 - exthandler should not export as many headers

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

EXPORTS =       nsExternalHelperAppService.h \
                nsExternalProtocolHandler.h \
                $(OSDIR)/nsOSHelperAppService.h \
                nsHelperAppRDF.h            \
                        $(NULL)
of those, only nsExternalHelperAppService.h is used outside of docshell/build
and uriloader/exthandler:
/camino/src/download/nsDownloadListener.h, line 54 -- #include
"nsExternalHelperAppService.h"
there's probably no good reason for that, but I'll investigate that in another
bug. for this bug, I'll just remove the other three files from EXPORTS.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 140072 [details] [diff] [review]
patch

sr=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 140072 [details] [diff] [review]
patch

actually camino was now changed to no longer include that header -> I can
remove the entire EXPORTS statement

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 140073 [details] [diff] [review]
patch v2

arg, damnit, this requires a bit more thought (because docshell needs to
include nsOSHelperAppService.h)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v3

ok, this works

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140076 [details] [diff] [review]
patch v3

r=bzbarsky

Comment 8

[Darin Fisher]

Comment on attachment 140076 [details] [diff] [review]
patch v3

sr=darin

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in Makefile.in;
/cvsroot/mozilla/uriloader/exthandler/Makefile.in,v  <--  Makefile.in
new revision: 1.49; previous revision: 1.48
done