232456 - Escape key doesn't cancel Gtk alerts

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Crispin Flowerday (not receiving bug mail)]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040122 Galeon/1.3.12

According the the GNOME keynav guidelines, the "Cancel" button should be
activated by the Escape key:

http://developer.gnome.org/projects/gap/keynav/gtk_buttons.html

For the GTK alerts (e.g. resubmit POST data on reload), this is not the case

Reproducible: Always
Steps to Reproduce:
1. Open TestGtkEmbed
2. Go to http://bugs.flowerday.cx/post.cgi
3. Click the button
4. Hit refresh (the resubmit post data dialog should appear)
5. press escape

Actual Results:  
the dialog isn't cancelled

Expected Results:  
The dialog should be cancelled, just like it would be if the cancel button was
pressed.

Comment 1

[Crispin Flowerday (not receiving bug mail)]

Attachment: Patch

GtkDialogs already provide the ability to cancel the dialog when the Escape
button is pressed, you just need to use the GTK_RESPONSE_CANCEL return code.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in