232520 - nsImageBeOS needs cleanup

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Sergei Dolgov]

Do we really need to recreate image (inlcluding delete/new BBitmap and copyying
again all bytes) in ::ImageUpdated()?(Win and OS/2 don't do it.)
 And we are working permanently with single B_RGBA32 format, all remaining
color-space related conversions is work of app-server.

Do we really need anything in ::Optimize()? At least until we don't deal with
BDirectWindow.

Also ::DrawToImage(). Tor has plans to remove it from nsImagePlatform, but now
it  is hardly optimized - too much arithmetics in loops.

Comment 1

[Sergei Dolgov]

Simon, i think all nsImage optimization will go here, incl. changes you planned

Comment 2

[Sergei Dolgov]

2 tangobravo.
Btw, one if improvements may be use of cached tmpbitmap, as i did for other
objects in JetGFX patches. Thread-safe place for this purpose is nsSurfaceBeOS.
Here is what i mean:
To avoid newing/deleting tmptile bitpmap, we may have permanent bitmap, not big,
but effective for most cases, about 160 KB, to say - 200*200. If tile image is
less than those dimensions, we will use it (as now with your patches we use
exact restricted rects as DrawToBitmap arguments.
And only if tile image is larger, we will get it from heap.

Comment 3

[Sergei Dolgov]

Attachment: Patch (diff -up4)

Rewrite of DrawTile() - using offsets and decoded rect
Rewrite of other methods to use decoded rect.
#include imgScaler.h removed - we're using native scaling.

Comment 4

[Sergei Dolgov]

Comment on attachment 144423 [details] [diff] [review]
Patch (diff -up4)

review request.

Comment 5

[Sergei Dolgov]

Setting target milestone.

P.S. to Simon abput patch.
After some experiments i simplified DrawTile code to always use tiled bitmap. No
big overhead according my test, but removes several issues on drawing of complex
multilayered pages with transparency etc

Comment 6

[Sergei Dolgov]

Comment on attachment 144423 [details] [diff] [review]
Patch (diff -up4)

changing reviewer

Comment 7

[tqh]

Comment on attachment 144423 [details] [diff] [review]
Patch (diff -up4)

I've looked at the patch and to me it looks ok. DrawToImage part is a bit hard
for me to confirm though.

(It applies and works nicely)

Comment 8

[Sergei Dolgov]

checked in 2004-06-13 11:27
"Bug 232520, nsImageBeOS needs cleanup. Optimized DrawTile, DrawToImage,
implemented partial image update, crash-leak in DrawToImage removed.
r=[e-mail]"

Comment 9

[Niels Reedijk]

Checked in on AVIARY by db48x%yahoo.com: 
 
Check in several BeOS bugs that are already checked in on the trunk. All are 
r=twh ([e-mail]) except the last which is r=Sergei Dolgov 
([e-mail]). a=carte blanche ([03:53:40] 
<nielx!~nielx@84.119.151.125> We've been basically given a carte blanche for 
any change that involves the beos-only code)