232544 - Input expand/collapse buttons don't work after ctrl+up/down

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Click the expand button
2. Press ctrl+down
3. Click the expand button
4. Press ctrl+up
5. Click the collapse button
6. Press ctrl+up
7. Click the collapse button
Steps 3 and 7 do not work as you expect them to.
Also when they do work the buttons seem to be much slower than the ctrl arrows.

Comment 1

[James Ross]

Taking.

Comment 2

[James Ross]

This appears to simply be the buttons using the pref for multiline mode (which
updates the box to the new mode) and the Ctrl shortcuts are directly updating
the box. Patch soon.

Comment 3

[James Ross]

Attachment: Dispatches a call to change the pref, rather than directly updating state.

Comment 4

[James Ross]

Comment on attachment 140278 [details] [diff] [review]
Dispatches a call to change the pref, rather than directly updating state.

Checked in.

Comment 5

[[e-mail]]

Ah, so the reason that the buttons were slower was that they went though the
event loop, while the keys just stomped on the state directly, and the keys are
now just as slow as the buttons :-/