232545 - Text included by <marquee></marquee> is not shown

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Klaus P. Kuhlemann]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040128 Firebird/0.8.0+

On websites using scrolling text by the <marquee>-tag, thw text inside of
<marquee></marquee> is not shown. This is only in 1.7a (firebird) about since
2004-01-15 nightly.
In Mozilla 1.6 works the scrolltext, even in firebird pre0.8 nighlies. 
Even old Netscape 4.x showed this text without scrolling, latest firebird shows
nothing at all.

Reproducible: Always
Steps to Reproduce:
1.Open a website with a <marquee>-scrolltext.
2.The text inside the <marquee></marquee> tags is not shown.
3.

Actual Results:  
Firebird failed to show the marquee-scrolling and don't show the text at all.

Expected Results:  
Performing the marquee-scrolling as Mozilla 1.6 does.

Comment 1

[Wayne Woods]

Agreed. There are other bugs that stop marquees being rendered in both Seamonkey
and Firebird (e.g. bug 208683) in certain situations, but this one seems to be
Firebird-specific (I'm using 20040120 Firebird/0.7+).

I'll attach a very simple text case to demonstrate.

Comment 2

[Wayne Woods]

Attachment: Very simple marquee

Open the attachment in both Firebird and Seamonkey and compare. The marquee
fails to function in recent builds of the former.

Comment 3

[Jason Barnabe (np)]

Bug also present in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a)
Gecko/20040118

->Browser - Layout: View Rendering

Comment 4

[HARUNAGA Hirotoshi]

confirmed also on 2004013105/Mac.
regression.
marking New.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Please don't confirm bugs that are pretty clearly in the wrong component.... 
Just opening the JS console would have told you this is NOT a layout error.

This works in build 2004-01-10-09 and is broken in build 2004-01-11-09.

Backing out the XBL sink changes from bug 229526 fixes this problem.

Comment 6

[Boris Zbarsky [:bzbarsky]]

The problem, of course, is that we are looking at
ocument.getAnonymousNodes(this)[0].firstChild.firstChild where the markup is:

283     <content>
284       <html:div xbl:inherits="" style="overflow: -moz-scrollbars-none">
285         <xul:hbox style="margin: 0 100%;">
286           <html:div>
287             <children/>
288           </html:div>
289         </xul:hbox>
290       </html:div>
291     </content>

The [0] thing is the outermost <html:div> since whitespace inside <content> _is_
stripped.  Its firstChild, however, is no longer the <xul:hbox> but the textnode
that we are no longer stripping from it.  And the textnode's firstChild is
undefined, of course (instead of being the inner <html:div>).

Fixing this up is easy-ish, but I wonder how much other XBL that does similar
things got broken by the change in bug 229526...

Comment 7

[[e-mail]]

Attachment: Proposed patch

Comment 8

[Doron Rosenberg (IBM)]

Comment on attachment 140495 [details] [diff] [review]
Proposed patch

Are such changes announced anywhere before they land?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140495 [details] [diff] [review]
Proposed patch

sr=bzbarsky, and please try to lxr for patterns that may have been broken by
the other patch, ok?

Comment 10

[[e-mail]]

Fix checked in.

A brief scan of LXR shows 5 classes of xml files that use the html namespace.
1) tests (don't use xbl)
2) obsolete (don't use xbl)
3) pretty print (does not appear to be affected)
4) textbox multiline="true" (already fixed)
5) this bug

So, hopefully, there isn't anything left to fix.

Comment 11

[Boris Zbarsky [:bzbarsky]]

So can this be marked fixed?

Comment 12

[[e-mail]]

Whoops, did I forget to select the knob :-(

Comment 13

[Wayne Woods]

The notorious marquees work fine, once again :) 20040204 Firebird/0.8.0+