232570 - respect ldap2.server.position values for ab pane and search order

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[David :Bienvenu]

We need the .position pref value, which is settable by MCD, to control the order
that ldap servers appear in the ab pane, and to control the search order for
auto-complete (the latter might already work - I don't know).

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this patch does the following:
1. Replace nsISupportsArray with nsCOMArray for mSubDirectories member
2. Propagate server position to dirProperties.
3. Use serverPosition to sort ab pane servers.
4. Sort directory server list by position

Item 1 is not needed - I thought it was going to be useful so we could sort
mSubDirectories, but that hasn't turned out to be needed, yet. It's useful
cleanup, however.

Item 4 may not be needed - the idea is that there would be some code that would
just iterate over the dir servers so having them sorted by position would just
do the right thing - this is what 4.x did as well. This should control the
order that local directories are searched against, but it won't control the
order that ldap servers are autocompleted against since we only autocomplete
against a single ldap directory.

Comment 2

[David :Bienvenu]

Comment on attachment 140677 [details] [diff] [review]
proposed fix

Scott, let me know if you think the nsISimpleEnumerator/nsCOMArray stuff is too
risky.

Comment 3

[David :Bienvenu]

fixed on trunk and .5/m4 branch