232591 - Expose name validation methods from the XML parser (expat)

Status: RESOLVED FIXED

(Core :: XML, defect, P3)

Description

[Johnny Stenback (:jst)]

We've got bugs in our code due to the lack of code that can check if a string is
a valid XML name (qname or just name, etc). It'd be totally cool if the XML
parser could expose such functionality, since it already has it, for sure.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

ideally nsIExpatSink should have namespaced methods rather then the current ones
IMHO. That way we wouldn't need to resolve namespaces in so many different
codepaths.

Btw, i just noticed yesterday that xul-sink sets the wrong namespace to
attributes named 'xmlns' (kNameSpaceID_None rather then kNameSpaceID_XMLNS)

Comment 2

[Johnny Stenback (:jst)]

True, but we still need this for validation of names in places like
document.createElement() etc.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: v1 (expat/htmlparser)

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1 (transformiix)

This converts Transformiix to use the new stuff and removes the implementation
that we had in Transformiix.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 140449 [details] [diff] [review]
v1 (expat/htmlparser)

What do you think? Note that I have a patch for bug 16603 that adds the
necessary calls to all the DOM methods that need this (I'm holding off on
attaching that until we finalize this one).

Comment 6

[Axel Hecht]

tx part looks good to me

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 140449 [details] [diff] [review]
v1 (expat/htmlparser)

sr=jst

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 140450 [details] [diff] [review]
v1 (transformiix)

mmmm... coderemoval

Comment 9

[Peter Van der Beken [:peterv]]

Much to my surprise, when running XSLBench (not a really good testcase for these
changes, but anyway) almost all tests got a very small speedup.

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: v1 (transformiix)

Now with Makefiles

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 140548 [details] [diff] [review]
v1 (transformiix)

sr=jst