232594 - navigation keys (alt+left arrow: VK_LEFT, alt+right arrow: VK_RIGHT) shouldn't be hard coded

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Tsahi Asher]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.6) Gecko/20040113

in the Go menu you can see that you can go back in history by pressing alt+left
arrow, and forward with alt+right arrow.
that's fine as long as you're using a LTR language pack. however i made modified
 themes for using with a RTL language pack. with such a language pack, the
interface is flipped right to left. therefore, in the modified theme, the back
button naturally has an arrow pointing right on it, and the forward arrow has an
arrow pointing left on it, in contrast to the navigation keys.

therefore, the accesskeys for going back and forward should be modifiable via
the language pack, so a localizer of a RTL language pack will be able to decide
which are best for his locale.

Reproducible: Always
Steps to Reproduce:
1. install a hebrew/arabic/persian language pack
2. press alt+left arrow

Actual Results:  
you go back in history

Expected Results:  
you go forward in history

Comment 1

[Simon Montagu :smontagu]

Neil, can we use keycode values like VK_LEFT and VK_RIGHT in localizable
accesskey definitions?

Comment 2

[Tsahi Asher]

(In reply to comment #1)
> Neil, can we use keycode values like VK_LEFT and VK_RIGHT in localizable
> accesskey definitions?

VK_F3 is already used throughout the language pack to open the Find dialog box,
and VK_RETURN is also used twice.

hey, this Reply thing is realy neat :)

Comment 3

[[e-mail]]

Attachment: Put keys in language specific files

Putting the keybindings in platform-region files should work, right?
(IIRC ar-mac.jar, ar-unix.jar, ar-win.jar, he-mac.jar etc.)

Comment 4

[Tsahi Asher]

why do you think it should be in platform specific, and not in platform neutral
(like en-US.jar)?

Comment 5

[[e-mail]]

(In reply to comment #4)
> why do you think it should be in platform specific, and not in platform
> neutral (like en-US.jar)?
The .xul file is already platform specific - macs use different modifiers.

Comment 6

[Tsahi Asher]

and another thing: the localization note format is
<!-- LOCALIZATION NOTE (entity_name): comments -->

Comment 7

[[e-mail]]

So what's the format for a 4 entities (or file-wide!)?

Comment 8

[Tsahi Asher]

never mind, i didn't notice it's for two entities each.

Comment 9

[Simon Montagu :smontagu]

Comment on attachment 140238 [details] [diff] [review]
Put keys in language specific files

Don't you want to make "[" and "]" localizable as well on Mac (as they already
are on Unix)?

Comment 10

[Simon Montagu :smontagu]

Comment on attachment 140238 [details] [diff] [review]
Put keys in language specific files

r=smontagu with that change and the other things we discussed on IRC (i.e.
adding	<!DOCTYPE overlay SYSTEM ... where necessary -- I'll leave it up to you
whether to merge the .dtds)

Comment 11

[[e-mail]]

Attachment: Also localize alternate Mac keybindings

Comment 12

[jag (Peter Annema)]

Comment on attachment 140268 [details] [diff] [review]
Also localize alternate Mac keybindings

sr=jag

Comment 13

[[e-mail]]

Fix checked in.