232607 - add ui for smooth scroll preference

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

to allow users to find this preference easier, the preference dialog should have
an option for it.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 140208 [details] [diff] [review]
patch

>+pref("general.smoothScroll", false);
I don't think this is the best place for this pref, e.g. in case someone needs
to change the default for some obscure OS.

>+    <checkbox id="enableSmoothScroll"
>+              label="&enableSmoothScroll.label;"
>+              accesskey="&enableSmoothScroll.accesskey;"
>+              prefstring="general.smoothScroll"/>
I'm not convinced exactly where the best place for this checkbox is.

>+<!ENTITY enableSmoothScroll.label "Enable smooth scrolling">
"Use", rather than "Enable", please (also above).

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

per irc discussion, make the checkbox the third one in that dialog

Comment 4

[[e-mail]]

Comment on attachment 140264 [details] [diff] [review]
patch v2

>+      "useSiteIcons", "enableAutomaticImageResizing", "useSmoothScroll"
Hmm... do we normally keep these in order?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 140264 [details] [diff] [review]
patch v2

no idea if we do, but ok, I'll swap useSmoothScroll and
enableAutomaticImageResizing in the array

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in