232642 - [ActiveX] crash if access twice the same html element

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Alexandre Trémon]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

crashes in
http://lxr.mozilla.org/seamonkey/source/nsprpub/lib/ds/plhash.c#301


Reproducible: Always
Steps to Reproduce:
This VB exemple crashes:

Dim document As HTMLDocument
Dim body1, body2 As IHTMLElement
Set document = MozillaBrowser1.document
Set body1 = document.body
Set body2 = document.body

Comment 1

[Alexandre Trémon]

Attachment: Defines valueCompare callback for the PL_HashTable structure used

When calling PL_NewHashTable, a NULL PLHashComparator is passed as
'valueCompare' parameter. Pass the same compare function as for the
'keyCompare' parameter: a function that compares the values of pointers

Comment 2

[Adam Lock]

Comment on attachment 140230 [details] [diff] [review]
Defines valueCompare callback for the PL_HashTable structure used

r=adamlock

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 140230 [details] [diff] [review]
Defines valueCompare callback for the PL_HashTable structure used

sr=jst

Comment 4

[chris hofmann]

Comment on attachment 140230 [details] [diff] [review]
Defines valueCompare callback for the PL_HashTable structure used

a=chofmann for 1.7a  need to land quickly if you want  to make the train.. 
thanks

Comment 5

[timeless]

Checking in mozilla/embedding/browser/activex/src/common/IEHtmlNode.cpp;
/cvsroot/mozilla/embedding/browser/activex/src/common/IEHtmlNode.cpp,v  <-- 
IEHtmlNode.cpp
new revision: 1.3; previous revision: 1.2
done

Please resolve this if it's fixed

Comment 6

[Alexandre Trémon]

What am I supposed to do?
Write "1.3" after ",v" ?

Other question: how do I change the 'assigned to' ?

Comment 7

[Michael Lefevre]

Alexandre - You can change who this a bug is assigned to by filling in the
"reassign bug to" box in the form, selecting the button next to it and clicking
commit. However, this bug has been assigned to you, which is correct.

What you need to do is check if the problem is fixed in a new build of Mozilla
containing your patch, and then you can select "Resolve bug, changing resolution
to FIXED" and commit.

Comment 8

[chris hofmann]

marking fixed, so it gets on the test radar

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed for 1.7a, no need to block 1.7b

Comment 10

[Mike Kaply [:mkaply]]

Can someone put this in for 1.4.2 or should I?