232784 - Attempting to download a file to a write protected folder results in a crash (nsExternalAppHandler::SaveToDisk(nsIFile*, int)

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Chris Petersen]

Build: 2004013103
Platform: OS X 10.3.2
Expected Results: Attempting to dl a file to write protected folder should
result in a error warning like 'Cannot save or write file'.
What I got: Application crashes

Steps to reproduce:

1) In Terminal, set folder to have no write access on the computer's local drive
chmod u= folder name
2) Launch Camino and use Camino's preferences to specify this particular folder
as the default download folder
3) Attempt to download a file in Camino
4) This results in a crash

Comment 1

[Chris Petersen]

Attachment: stack trace

Comment 2

[Mike Pinkerton (not reading bugmail)]

pushing to biesi per our conversation. we should proably not let it get into the
state where mOutStream was null.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 140615 [details] [diff] [review]
patch

r=pink, this fixes it for me.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

-> browser:file handling, as that's where the bug is

hm. seamonkey/win2k doesn't seem to crash when I make $TEMP unwritable. I wonder
why... I even get an error dialog (with a wrong message, but still)

with the patch, I get the expected dialog (that mozilla can't write to the
target dir because of missing permissions)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140615 [details] [diff] [review]
patch

sr=bzbarsky

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 8

[Chris Petersen]

Excellent.. This has been fixed in the Camino 2004020603 NB under 10.3.2. I now
get a sheet that states "file can't be saved, because you cannot change the
contents of that folder". Need to check the mac mozilla trunk build too.

Comment 9

[Chris Petersen]

Verified fixed in the Macho Mozilla 2004020605 Trunk build.