232892 - imap folders which get new mail filtered nto them by client-side filters not getting counts updated or green arrow

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

Imap folders which get new mail filtered into them by client-side filters are
not getting counts updated or green arrow on the folder, until the folder is
selected in the UI. This is a regression from some code that attempted to fix
counts when the server reports a different unread count than what we think we
have in the folder.

Comment 1

[David :Bienvenu]

Attachment: prop

I think the sync Counts code is causing this problem...

Comment 2

[David :Bienvenu]

actually, that can't be the problem...since that's only called when you click on
the folder.

Comment 3

[David :Bienvenu]

My current thinking is that this has to do with filters that move messages to
the trash - the code attempts to mark those messages read in the trash, but it
doesn't work. However, it does prevent us from updating the unread msg count on
the trash because locally we think the msg is read. I can either try to fix it
so the messages are marked read in the trash (by marking them read in the inbox
before the move happens), or just remove the code that marks the msg read locally.

Comment 4

[David :Bienvenu]

OK, the trash problem is a real problem, but the much more general problem is
that we're marking the source messages read when messages are moved/deleted, and
in some situations, we notice that the messages have been marked seen before we
update the pending counts in the target folder, and think that the msg is /SEEN
in the dest folder as well.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

count unread messages before we do the move/copy, and use that count when done.
Also, for doing fcc to imap folder, set total count to 1, so sent folder count
will increment correctly.

Comment 6

[David :Bienvenu]

Attachment: fix that doesn't increment drafts total count on each save

better fix - don't increment total count if we're a draft or template.

Comment 7

[David :Bienvenu]

I removed the mark read for filtering to trash because it wasn't working - the
message was ending up unread in the trash.

Comment 8

[David :Bienvenu]

Attachment: fix for cross server case

it turned out the previous patch didn't handle the cross server case correctly.
This one does, and cleans up some unused code.

Comment 9

[David :Bienvenu]

fixed on trunk and m4 branch.

Comment 10

[David :Bienvenu]

marking fixed.