233019 - CERT_FindCertByKeyID crashes using NULL ptr

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

CERT_FindCertByKeyID is needed to find the CA cert that issued a CRL.
But the present implementation is badly broken.  
It uses a cert pointer that is always NULL.
I have coded and tested a fix.  
Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Marking p2 for NSS 3.10.  If desired, this patch can be put in 3.9.1

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch fixes several bugs:
1) it passes the correct pointer (not NULL) to SECITEM_ItemsAreEqual
2) It terminates the loop when it reaches the end of the circular 
   doubly-linked list of cert nodes
3) It frees the cert list before returning.
4) It sets the error code if it fails to find any matching certs.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 140570 [details] [diff] [review]
patch v1

Julien, Please review.

Comment 4

[Julien Pierre]

Comment on attachment 140570 [details] [diff] [review]
patch v1

Fix looks good.

It would be nice if we cached the certs by keyID in a hash table, rather that
looping over everything to do the lookup, but this would probably belong in
another layer (cert cache, stan?).

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/lib/certdb/stanpcertdb.c,v  <--  stanpcertdb.c
new revision: 1.63; previous revision: 1.62

Thanks for the review.