Closed Bug 233103 Opened 21 years ago Closed 21 years ago

inline getters/setters for twip/pixel scale factors on nsIDeviceContext

Categories

(Core Graveyard :: GFX, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

We should inline the getters and setters for the AppUnit/DevUnit/Twip/Pixel
scaling factors on nsIDeviceContext.  This will help me to inline
nsIPresContext::GetTwipsToPixels and GetPixelsToTwips as well.
Attached patch patchSplinter Review
This diff was created using the following substitution script:

grep -rl GetAppUnitsToDevUnits .|xargs perl -pi -e
"s/(\s*)(\S*)GetAppUnitsToDevUnits\( *([^ \)]*) *\)/\1\3 =
\2AppUnitsToDevUnits\(\)/g"

(repeated for each of the getters).

I had to do a couple of manual fixups after that, but other than that it did
the job nicely.
Attachment #140632 - Flags: superreview?(dbaron)
Attachment #140632 - Flags: review?(dbaron)
Attachment #140632 - Flags: superreview?(dbaron)
Attachment #140632 - Flags: superreview+
Attachment #140632 - Flags: review?(dbaron)
Attachment #140632 - Flags: review+
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: