Closed
Bug 233103
Opened 22 years ago
Closed 22 years ago
inline getters/setters for twip/pixel scale factors on nsIDeviceContext
Categories
(Core Graveyard :: GFX, defect)
Core Graveyard
GFX
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
66.63 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
We should inline the getters and setters for the AppUnit/DevUnit/Twip/Pixel
scaling factors on nsIDeviceContext. This will help me to inline
nsIPresContext::GetTwipsToPixels and GetPixelsToTwips as well.
![]() |
Assignee | |
Comment 1•22 years ago
|
||
This diff was created using the following substitution script:
grep -rl GetAppUnitsToDevUnits .|xargs perl -pi -e
"s/(\s*)(\S*)GetAppUnitsToDevUnits\( *([^ \)]*) *\)/\1\3 =
\2AppUnitsToDevUnits\(\)/g"
(repeated for each of the getters).
I had to do a couple of manual fixups after that, but other than that it did
the job nicely.
![]() |
Assignee | |
Updated•22 years ago
|
Attachment #140632 -
Flags: superreview?(dbaron)
Attachment #140632 -
Flags: review?(dbaron)
Attachment #140632 -
Flags: superreview?(dbaron)
Attachment #140632 -
Flags: superreview+
Attachment #140632 -
Flags: review?(dbaron)
Attachment #140632 -
Flags: review+
![]() |
Assignee | |
Comment 2•22 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•