233145 - stop implementing nsIURIContentListener in nsExternalAppHandler

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

there is no real reason for this. RetargetLoadNotifications can just set
loadgroup and notificationCallbacks to nsnull.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

this also makes nsIINterfaceRequestor unnecessary

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140663 [details] [diff] [review]
patch

>Index: nsExternalHelperAppService.cpp
>-  // make our docloader release the progress listener from the progress window...
>-  if (mLoadCookie && mWebProgressListener) 

and so on.  This part bothers me -- I have no idea what it does and why (and
more importantly whether not doing it leaks).

Other than this one caveat, this looks great.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

bz: nothing calls closeProgressWindow. Changing this function does therefore not
affect any possible leaks.

I have no idea why that function exists, too...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140663 [details] [diff] [review]
patch

r=bzbarsky

Comment 6

[Darin Fisher]

Comment on attachment 140663 [details] [diff] [review]
patch

sr=darin

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in