233160 - Separate style overlays out of nsIChromeRegistry

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Benjamin Smedberg]

From my chrome interface separation proposal
(http://bdsmedberg.no-ip.org/chrome/) separate out the style overlays, just like
I separated out the XUL overlays. When implementing this, I found that the
category is just too complicated and unncessary, so I ditched it and folded the
style overlays into the same nsIXULOverlayProvider interface.

Comment 1

[Benjamin Smedberg]

Attachment: checkpoint changes, works in FB

This is a checkpoint patch, not ready for review yet. It works in firebird, but
breaks seamonkey, minimo, and pretty much everything else ;)

Comment 2

[Benjamin Smedberg]

Attachment: complete patch for sea/ff/minimo

OK, here is the full patch for review. This moves all user/agent sheet logic
out of the chrome registry into layout. nsIChromeRegistry is down to three
methods!

Comment 3

[Boris Zbarsky [:bzbarsky]]

I may not get to this for a week or so.

Comment 4

[Boris Zbarsky [:bzbarsky]]

In fact, I have no idea when I'll be able to get to this....

Comment 5

[David Hyatt]

Comment on attachment 140978 [details] [diff] [review]
complete patch for sea/ff/minimo

This looks great. sr=me

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's really a stylesheet cache, not a style cache.

Also, I wonder if we should do anything related to bug 179006.  Probably not...

Maybe more later...

Comment 7

[Benjamin Smedberg]

I'm definitely thinking about 179006, but not in this bug.

Comment 8

[Benjamin Smedberg]

Comment on attachment 140978 [details] [diff] [review]
complete patch for sea/ff/minimo

dbaron, do you want to do a full review?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm not going to have a chance to do a full review of this before 1.7b, so I'm
OK with it just going in, assuming you rename to nsLayoutStylesheetCache.  But
bz might want to have a look.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 140978 [details] [diff] [review]
complete patch for sea/ff/minimo

>+        char *str = ToNewCString(sheets);
>+        char *newStr;
>+        char *token;
>+        while ( (token = nsCRT::strtok(str, ", ", &newStr)) ) {

Your condensation of the two strtok calls into one was incorrect.  You need:

char *str = ToNewCString(sheets);
char *newStr;
char *token = str;
while ( (token = nsCRT::strtok(token, ", ", &newStr)) ) {

Comment 11

[Boris Zbarsky [:bzbarsky]]

I have no time to do more than skim before freeze... the interface looks ok,
though we will eventually need to move user/agent sheets elsewhere.  The other
changes look fine in general.. (again, I didn't read the details).

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 140978 [details] [diff] [review]
complete patch for sea/ff/minimo

You landed this, right?

Comment 13

[Benjamin Smedberg]

yes, this went in before the 1.7b freeze