233188 - Spaces / hyphen / dash in filename causes incorrect download filename

Status: VERIFIED DUPLICATE of bug 221028

(Core Graveyard :: File Handling, defect)

Description

[Ming Liu]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

With the Horde PHP e-mail system, a file that has been attached to an email with
a hyphen between spaces in the filename causes the suggested filename to be
truncated in the download dialog box. 

For example, "1 - Intro.doc" would have the name truncated to "1" when asked to
be downloaded. Unsure if this problem happens with generic files outside of
Horde, or whether it's the space or the hyphen/dash that is causing the problem.

The filename is correct in Galeon, so it's likely not a Horde problem.

Reproducible: Always
Steps to Reproduce:
1. click the download link on the web page (link to a PHP script)
2. the dialog will pop up with the truncated name; click Save it to Disk and OK
3. the filename prompt will still have the truncated filename

Actual Results:  
The filename came out truncated. Examples are here:
http://www.eng.uwaterloo.ca/~mliu/mozbug01.png
http://www.eng.uwaterloo.ca/~mliu/mozbug02.png
http://www.eng.uwaterloo.ca/~mliu/mozbug03.png

Expected Results:  
The filename should have been complete. Example in Galeon:
http://www.eng.uwaterloo.ca/~mliu/galeon.png

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is the page sending a malformed Content-Disposition header (forgetting to quote
a filename containing spaces)

What build is your Galeon based on?  We recently had to tighten up the parsing
of that header and drop support for some malformed variants... so if you're
using an old Gecko in Galeon, this is indeed likely to be a Horde problem.

Comment 2

[Ming Liu]

(In reply to comment #1)
> Is the page sending a malformed Content-Disposition header (forgetting to quote
> a filename containing spaces)
> 
> What build is your Galeon based on?  We recently had to tighten up the parsing
> of that header and drop support for some malformed variants... so if you're
> using an old Gecko in Galeon, this is indeed likely to be a Horde problem.


I forgot to mention that despite the truncated filename, the file downloads
properly in Mozilla and a manual renaming "fixes" the problem (thus the minor
severity).

I am using Galeon 1.3.9.

Here is the actual link in Horde:
https://www.nexusmail.uwaterloo.ca/horde/imp/view.php?thismailbox=INBOX&index=1882&id=3&actionID=112&mime=f9eb7642bdba5bc4f4ab7a8a5a485774&f=/5+-+Hardware+Interrupts+-+0204.doc

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I am using Galeon 1.3.9.

That's actually not relevant.  What's relevant is what version of Gecko you're
using in Galeon... What's the exact user-agent string?

> Here is the actual link in Horde:

That requires a login.  Can you get an HTTP log of loading just that page using
the instructions at
http://www.mozilla.org/projects/netlib/http/http-debugging.html and attach that
log here?

Comment 4

[Ming Liu]

> That's actually not relevant.  What's relevant is what version of Gecko you're
> using in Galeon... What's the exact user-agent string?

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030915 Galeon/1.3.9

> That requires a login.  Can you get an HTTP log of loading just that page using
> the instructions at
> http://www.mozilla.org/projects/netlib/http/http-debugging.html and attach that
> log here?

Yes, the link was just for reference, and wasn't meant to be visited. The log
file is too big (~700K), so I've placed it at:
http://www.eng.uwaterloo.ca/~mliu/log.txt

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yeah, 1.4 is really old.

From that log:

  content-disposition: attachment; filename=5 - Hardware Interrupts - 0204.doc

Note the lack of quotes around the filename; those are required if spaces are in
the filename....

Please report this to the horde maintainer for uwaterloo.ca....

*** This bug has been marked as a duplicate of 221028 ***

Comment 6

[Ming Liu]

Oh, I see. Sorry about that, and thanks for your time.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

verified.