233239 - zlib.h, libzlib.a, secutil.h, and libsectool.a should not be included in NSS binary distributions

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Wan-Teh Chang]

zlib.h, libzlib.a, secutil.h, and libsectool.a are
only used by NSS commands and should not be included
in NSS binary distributions.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

The motivation for this bug report is that an
NSS user accidentally picks up the zlib.h in
our distribution.

Comment 2

[Robert Relyea]

Comment on attachment 140718 [details] [diff] [review]
Proposed patch

r=relyea

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 140718 [details] [diff] [review]
Proposed patch

I haven't test this, and NO_MD_RELEASE is used nowhere else so my confidence in
that feature is not high.  But if NO_MD_RELEASE doesn't work, that is a
separate bug. r=MisterSSL

Comment 4

[Wan-Teh Chang]

Attachment: Proposed patch v2

The previous patch doesn't build.  Sorry.
It has two problems:

1. The Makefiles need to have a private_export target
in order to export the headers listed in PRIVATE_EXPORTS.

2. cmd/lib and cmd/zlib define their MODULE to be seccmd,
but almost all NSS commands define their MODULE to be nss.
So they can't use the private headers of seccmd, which is
treated as another module.  In this patch I use the easiest
fix: make cmd/lib and cmd/zlib define their MODULE to be
nss, too.  Longer term, we should decide whether the NSS
commands should be in the 'nss' or 'seccmd' MODULE.

Comment 5

[Wan-Teh Chang]

Comment on attachment 140770 [details] [diff] [review]
Proposed patch v2

I checked in this patch.

Checking in lib/Makefile;
/cvsroot/mozilla/security/nss/cmd/lib/Makefile,v  <--  Makefile
new revision: 1.3; previous revision: 1.2
done
Checking in lib/manifest.mn;
/cvsroot/mozilla/security/nss/cmd/lib/manifest.mn,v  <--  manifest.mn
new revision: 1.8; previous revision: 1.7
done
Checking in makepqg/manifest.mn;
/cvsroot/mozilla/security/nss/cmd/makepqg/manifest.mn,v  <--  manifest.mn
new revision: 1.5; previous revision: 1.4
done
Checking in zlib/Makefile;
/cvsroot/mozilla/security/nss/cmd/zlib/Makefile,v  <--	Makefile
new revision: 1.4; previous revision: 1.3
done
Checking in zlib/manifest.mn;
/cvsroot/mozilla/security/nss/cmd/zlib/manifest.mn,v  <--  manifest.mn
new revision: 1.5; previous revision: 1.4
done

I will examine tomorrow's NSS daily build to verify
that this patch does what it intends to do.

Comment 6

[Wan-Teh Chang]

I verified that the 20040211.1 daily build does not
include zlib.h, zconf.h, and secutil.h in xpheader.jar
and does not include libsectool.a in mdbinary.jar.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.