233274 - for/in loop goes through array elements in wrong order

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Hannes Wallnoefer]

User-Agent:       
Build Identifier: 

When an array is built using an array literal and elements are added to the
array later on (using array[x]=y or array.push(y)), looping through it with a
for-in loop goes through elements in wrong order. It seems the elements added
later are always processed first.

Reproducible: Always
Steps to Reproduce:
Rhino 1.5 release 5 0000 00 00
js> var array = [1, 2, 3];
js> array.push(4);
4
js> for (var i in array) print(i);

Actual Results:  
3
0
1
2

Expected Results:  
0
1
2
3

Comment 1

[Hannes Wallnoefer]

Reassigning to Igor (hope that's ok ;-)

Comment 2

[Igor Bukanov]

Attachment: Fix: populate ids array in NativeArray with dense indexes first

Since array literals in Rhino creates instances of NativeArray with the
internal dense array containing literal elements, the patch changes
NativeArray.getIds to return ids array with dense indexes coming first and
indexes for elements added later after that.

Comment 3

[Igor Bukanov]

I committed the fix

Comment 4

[Igor Bukanov]

Trageting as resolved against 1.5R5