233275 - spell checker incorrectly replaces words on double-click

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[kevin fisher]

User-Agent:       
Build Identifier: Mozilla Thunderbird 0.5a (20040128)

Double-clicking blank space, or even the scroll bar up/down arrows, in the
suggested words box of the spell checker always replaces the word being checked
by the highlighted suggestion (should instead do nothing).

Reproducible: Always
Steps to Reproduce:
1. Compose a new message: "spellng is gud" is an example
2. Spell check the message
3. 'spellng' is highlighted; double click the empty space below suggested word
and/or
4. 'gud' is highlighted; double click the scroll bar's up/down arrows in the
suggested word box

Actual Results:  
'spellng' is replaced with 'spelling' and/or 'gud is replaced with 'sud'

Expected Results:  
If anything, the highlighted selection should be un-highlighted in both instances.
No words should be replaced, and the spell checker should not move on to another
word.

Not sure if this also works when double-clicking the scroll bar between the
up/down arrows -- it doesn't in the 'gud' example.

Comment 1

[timeless]

bug 222541

Comment 2

[[e-mail]]

Also if there are no suggestions then double-clicking is the same as ignore.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 146180 [details] [diff] [review]
Proposed patch

r=[e-mail]

Comment 5

[[e-mail]]

Fix checked in.

Comment 6

[Scott MacGregor]

fixed on the tbird 0.6 branch