233292 - remove "empty damage rect" warning in nsFrame::Invalidate

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the "empty damage rect" warning is silly.  Function call overhead isn't
that high, and the code for checking emptiness could easily be in both places or
just inside nsFrame::Invalidate.  Furthermore, the flow of control shouldn't be
different in DEBUG and non-DEBUG builds.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Also use const in a few places to get rid of DEBUG-only warnings.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 140755 [details] [diff] [review]
patch

Hear hear!

The code should definitely be in the callee, not the caller, because there are
always more callers than callees

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2004-02-06 15:11 -0800.

Comment 4

[Boris Zbarsky [:bzbarsky]]

We have a lot of callers that _do_ check the emptiness of the rect... should
those checks be removed as convenient?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It doesn't matter to me.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

bz: I think so