233299 - nsIFilePicker.show is not reentrant

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

I have code which tries to write to a file when it gets an event.
to write to the file it pops up a filepicker and asks for a filename.
unfortunately the code can get an event at some time during the filepicker show
method's lifespan.

a variant of this exists on linux and was reported to me (i believe by doron).

Anyway, here's the windows code:


 90 NS_IMETHODIMP nsFilePicker::ShowW(PRInt16 *aReturnVal)  
115   mUnicodeFile.SetLength(0);
137           mUnicodeFile.Append(fileBuffer);
280         mUnicodeFile.Append(fileBuffer);

The case I care about goes through 280 (file picker) instead of 137 (directory
picker), but i believe the problem can happen in both places.

Anyway, the output is:

c:\\first.extc:\\second2.ens

For the time being, I'd like the second show() to clobber the first show.

This is done by changing Append to Assign. - There's no justification for Append.

Comment 1

[timeless]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140760 [details] [diff] [review]
patch

sr=bzbarsky

Comment 3

[timeless]

Attachment: os/2, beos

windows checked in

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 141036 [details] [diff] [review]
os/2, beos

r=mkaply

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141036 [details] [diff] [review]
os/2, beos

sr=bzbarsky

Comment 6

[timeless]

Comment on attachment 141036 [details] [diff] [review]
os/2, beos

i'm not following bugs (work priorities and no real home network) so if someone
approves this, i'd appreciate it if they checked it in.

risk: minimal.
if no one checks this in before branch, then someone should probably fix
'firts' to 'first' ...

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 141036 [details] [diff] [review]
os/2, beos

a=dveditz for 1.7a

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

(timeless checked the second patch here in 02/15/2004 21:31, making the
firts->first change)

Comment 9

[chris hofmann]

marking fixed