233451 - white-space at end of line doesn't collapse when followed by out-of-flow element

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Testcase coming up.  The problem is that the text frames get rendered if there
is a placeholder after them.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Happens in standards mode too.

Ian, is that the right behavior?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a whitespace collapsing bug.  If you remove the whitespace before the
out-of-flow element, the bug goes away.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's probably worth starting with the loop in
nsLineLayout::TrimTrailingWhiteSpaceIn, but fixing this probably requires
returning additional status from nsIFrame::TrimTrailingWhiteSpace.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Or we could do this...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140899 [details] [diff] [review]
Or we could do this...

I suppose we could also use return values from nsIFrame::TrimTrailingWhiteSpace
and override it in textframes and placeholder frames to return "continue" or
something, but this seems simpler given how this code currently works.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, right.  I guess we already solve elsewhere the problem of collapsing
whitespace between text frames across placeholders, so PFD_NONEMPTYTEXTFRAME
won't be set -- I was thinking it would be.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed.