233524 - Publishing settings dialog should not preselect a publishing site

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I have received A LOT of feedback about the Publishing Settings dialog. When it
is opened, it preselects the default publishing site and people have to click
on "new site" to create one. That's confusing enough so many people modified
by mistake their default publishing site instead of creating a new one.
It is proposed to change the current behavior and stop preselecting the default
site.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 140961 [details] [diff] [review]
fix #1

brade/dbaron, could you r/sr please ?

Comment 3

[Kathleen :Brade]

One concern I would have is that someone is trying to publish but they don't
quite get the settings right.  If they come back to the dialog, wouldn't it be
better if their settings were already there?  (I'm coming from the perspective
that many users will only publish to one location.)

I would prefer to reorganize the dialog so that the "New Site" button is more
prominent or use other techniques to avoid the problem where people are changing
their default setting when they want a new setting.  One option would be to ask
the user if they really want to replace the settings if they change the host (or
some similar check).

Before we proceed with any patch, I'd like to know the rationale for whatever we
agree to.  :-)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 140961 [details] [diff] [review]
fix #1

sr=dbaron assuming you get peer review

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

brade: you propose to revamp the dialog, that's another bug. I am just dealing
here with the fact some people forget ftp:// because nobody told them about it,
and publishing does not work...

Comment 6

[[e-mail]]

Comment on attachment 140961 [details] [diff] [review]
fix #1

Looks safe enough to me.

Comment 7

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 140961 [details] [diff] [review]
fix #1

Requesting approval for 1.7 checkin: this bug is a long-standing problem, with
user feedback, the fix for the bug is trivial and harmless, and it is already
implemented and used in Nvu 0.20.

Comment 8

[chris hofmann]

Comment on attachment 140961 [details] [diff] [review]
fix #1

a=chofmann for 1.7

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in (trunk)