23362 - Collected Adresses Book not being populated

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[esther]

Using builds 20000106 on win98, mac and linux addresses are no longer being sent
to the Collected Addresses address book. Not sure when this broke, but it was
working.  On all 3 platforms, selecting a message the From address does not go
to the Collected.  With win98 and linux a To: recipient does not go to the
Collected Address Book.  Still checking Mac.

1. launch Messenger
2. Open the Address Book from the Tasks menu
3. Open your Collected address book and either delete all cards or just one card
that you know you have a message from in your Inbox.  Close Abook
4. In Messenger, Select a message from a person whose card you removed from the
Collected Address Book.
5. Open Address book again and view cards in Collected Abook.

Expected: N new card listed for the person whose message you just opened.
Result:A new card listed for the person whose message you just opened.

Comment 1

[esther]

Correction:
Result should read "N0 new card listed for the person whose message you just
opened."
Expected should read "A new card should be listed for the person whose message
you just opened."

Comment 2

[rickg]

We'd really like to see this for M13, but it's not dogfood.

Comment 3

[lchiang]

Collection address book is on the beta 1 "in" list so it should be functional.

Comment 4

[esther]

Using 2000011909m13 mozilla build on Mac this is still a bug.

Comment 5

[Phil Peterson]

Marking M14. cc bienvenu. David is this your bug?

Comment 6

[David :Bienvenu]

My guess would be that I'm not getting called anymore because of the new message
display stuff.

Comment 7

[Scott MacGregor]

This is my bug. I didn't think anyone would notice =) and I never got around to
filing a bug to go back and fix it later.

Re-assigning to me assuming candic doesn't object.

Comment 8

[Karen Huang]

Release Notes for M13.

Comment 9

[Phil Peterson]

Collected addresses has to work for beta1.

Comment 10

[Scott MacGregor]

I didn't see much in the way of apis for adding an address / full name pair to
an address book. The closest thing we have now is the nsIAbAddressCollector
interface which adds an email address. But it adds it to a hard coded address
book (the history AB) which is the wrong one.

We may want to bring up a partially filled address book card if the user selects
add to address book. If we do that, Paul can I bring up an AB card without bein
inside the address book xul framework?

Comment 11

[leger]

Putting dogfood in the keyword field.

Comment 12

[David :Bienvenu]

the history ab is the collected addresses - it's not the wrong one.

Comment 13

[David :Bienvenu]

Here's the code that used to do the trick:

nsresult
nsMimeXULEmitter::DoSpecialSenderProcessing(const char *field, const char 
*value)
{
	nsresult rv = NS_OK;
	if (!nsCRT::strcmp(field, "From"))
	{
		NS_WITH_SERVICE(nsIAbAddressCollecter, addressCollecter,
						kCAddressCollecter, &rv);
		if (NS_SUCCEEDED(rv) && addressCollecter)
			addressCollecter->CollectAddress(value);
	}
	return rv;
}

Comment 14

[Scott MacGregor]

David, forgive me. this comment went in the wrong bug. My comment about not
having the right API was intended for add sender to address book not collected
address books.

=)

Comment 15

[David :Bienvenu]

yes, I wondered about that :-)

Comment 16

[lchiang]

Clearing PDT- resolution for reconsideration.  One of the items on the beta1 
list is to have the collected address book functional.  If this is not the case 
and this bug gets the PDT- designation again, we should not advertise this 
feature then.

Comment 17

[sol]

When this feature was working, I showed it to several folks who loved it. I 
would really like to have this feature for beta1.

Comment 18

[Scott MacGregor]

Sol, I will definetly have this checked in for beta. It's only 3 or 4 lines of
javascript at the most.

Comment 19

[leger]

Putting on PDT- radar for beta1.  But do check this in.  Would not hold beta.

Comment 20

[Scott MacGregor]

In an effort to keep my promise to Sol, I just checked this in. We are now
populating the collected address book again with email addresses in the From field.

Comment 21

[sol]

Scott - thank you!!! I really appreciate this.

Comment 22

[Ben Bucksch (:BenB)]

Anyhow, I have in my mind, that addresses are only supposed to be collected on a
reply, not on read. I like the reply version better, because it prevents my
collected address book from being littered with spammer addresses and other
addresses, in which I'm not interested.

Is there a way to achieve the described functionality, e.g. via a pref?

(I know, that I can disable this feature completely, but that's not, what I
want.)

Comment 23

[Phil Peterson]

Yes, we plan to allow finer granularity of which addresses get collected in a
later milestone.

Comment 24

[esther]

Using build 2000-02-24 -09on Win and Linux and -08 on mac this is fixed.  
Verified.