233657 - (win) nsSound::OnStreamComplete comment is wrong and function is not oom friendly

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect)

Description

[timeless]

145 pavlov   1.10   if (string && stringLen > 0) {
146                   // XXX this shouldn't be SYNC, but unless we make a copy
of the memory, we can't play it async.
147                   // We shouldn't have to hold on to this and free it.

148 hyatt    1.19     mLastSound = (char *) malloc(stringLen);
149                   memcpy(mLastSound, string, stringLen);

150 pavlov   1.24 
151                   CWinMM& theMM = CWinMM::GetModule();
152                   theMM.PlaySound(mLastSound, nsnull, SND_MEMORY |
SND_NODEFAULT | SND_ASYNC);

153 syd      1.7    }

Actual blame for the async change lies w/ hyatt.

Comment 1

[timeless]

Attachment: sync comment and sync player for oom

Comment 2

[[e-mail]]

Comment on attachment 141038 [details] [diff] [review]
sync comment and sync player for oom

r=me if you include a reminder to improve this when strings become sharable.

Comment 3

[timeless]

mozilla/widget/src/windows/nsSound.cpp 	1.33