Closed
Bug 233751
Opened 21 years ago
Closed 21 years ago
build fails on case sensitive HFS+ file system due to case-sensitivity typos in #includes
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: ch-moz2, Unassigned)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
benjamin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040210 Some #include directives reference non-canonical casings of #include'd files. This works fine on case- insensitive file systems, such as HFS+, but breaks on case-sensisitve file systems such as Case Sensitive HFS+. Reproducible: Always Steps to Reproduce: 1. Put source tree on a Case Sensistive HFS+ volume. 2. Build. Actual Results: build fails Expected Results: build should succeed
|
Reporter | |
Comment 1•21 years ago
|
||
|
||
Comment 2•21 years ago
|
||
Comment on attachment 141104 [details] [diff] [review] Proposed patch to fix #include directives r=me should I check this in?
Attachment #141104 -
Flags: review+
|
||
Updated•21 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 3•21 years ago
|
||
Comment on attachment 141104 [details] [diff] [review] Proposed patch to fix #include directives sr=bzbarsky. Yes, please land this if you have time to watch the tree.
Attachment #141104 -
Flags: superreview+
|
|
||
Comment 4•21 years ago
|
||
fixed-on-trunk. This affects both seamonkey and fire*, so you don't need a separate patch.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7alpha
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•