233979 - Outgoing SMTP settings for Use Name and Password are 'sticky'

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Brad Price]

User-Agent:       
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6) Gecko/20040113

When switching the "Default" among mulptiple Outgoing SMTP servers, whether the Use 
Name and Password box is checked is a factor of whether the last Default server used 
had that box checked, rather than whether the setting is defined for that server.

Reproducible: Always
Steps to Reproduce:
1. Set up two servers using Outgoing Server (SMTP) , Advanced, where Server A 
requires authentication, so the "Use Name and Password" is checked,  a username is 
filled in, and "TLS, if available" is selected.  Server B should not require authentication so 
the box is not checked, no name is specified and No is selected for secure connection.
2. Set the first server as the Default. Click OK.  When returned to the Outgoing Server 
(SMTP) Settings pane, the correct information for Server A is shown.  
3.  Click Advanced, select Server B, click Set Default, click OK
4. When returned the the Outgoing Server (SMTP) Settings pane, the information for 
Server B is automatically filled in, EXCEPT that the Use Name and Password box is 
checked, when it should not be!  
Conclusion:  the software seems to be "remembering" that setting if the previous "Default" 
server had the box checked.  In other words, this one preference seems to be 
"sticky".Reproduced

Actual Results:  
The Use Name and Password box is checked, when it should not be!

Expected Results:  
The Use Name and Password box should accurately represent what is defined for that 
server.

Reproduced this on more than one computer (all running the same Mac OS X and Moz 
1.6)

Comment 1

[Christian Eyrich]

The problem is a slightly other one.
If you have the box checked for the "Default" server, you can only disable it in
the Outgoing Server Settings main panel, not via Advanced/Edit.

Steps to Reproduce:
1. Set up a SMTP Server and check "Use name and password"
2. Choose the server in Advanced and click Edit
3. Uncheck "Use name and password"
4. Leave advanced

No problem to check the box in Advanced/Edit when it was unchecked box in the
main panel.

Comment 2

[Christian Eyrich]

Attachment: proposed patch

Not only set gSmtpUseUsername but unset it too, according to value of
gSmtpAuthMethod.

Comment 3

[David :Bienvenu]

     if (gSmtpAuthMethod.getAttribute("value") == "1")
         gSmtpUseUsername.checked = true;
+    else
+        gSmtpUseUsername.checked = false;

this can just be

gSmtpUseUserName.checked = (gSmtpAuthMethod.getAttribute("value") == "1");

do that, and r/sr=bienvenu

Comment 4

[Christian Eyrich]

Attachment: patch v2

Argh, of course. I suspected there's something simpler.

Comment 5

[Christian Eyrich]

Comment on attachment 141259 [details] [diff] [review]
patch v2

David, you're fast for me today. :)

Comment 6

[David :Bienvenu]

fix checked in, thx, Christian.