234030 - Docshell needs to deal with failure to get prefs

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

because as it is, this means that xul error pages accidentally default to on.
see:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsDocShell.cpp&branch=&root=/cvsroot&subdir=mozilla/docshell/base&command=DIFF_FRAMESET&rev1=1.579&rev2=1.580
which was:
1.580	jst%mozilla.jstenback.com	Feb 10 22:09	 	Fixing bug 68215. Adding support
for the onbeforeunload event. r=[e-mail], sr=[e-mail]

that was bad in that the variable for xul error pages no longer defaults to false.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

given how badly xul error pages work currently, I don't think they should be
enabled in 1.7a.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141241 [details] [diff] [review]
patch

sr=bzbarsky.

Comment 4

[chris hofmann]

Comment on attachment 141241 [details] [diff] [review]
patch

a=chofmann for 1.7a

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.582; previous revision: 1.581
done

Comment 6

[Malcolm Rowe]

Attachment: Fix unitialised member mValidateOrigin

mValidateOrigin is currently uninitialised if the pref isn't set. Fix that.
Also reorder some initialisers to match the declarations.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141341 [details] [diff] [review]
Fix unitialised member mValidateOrigin

sr=bzbarsky; please ping me when this needs checking in.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 141341 [details] [diff] [review]
Fix unitialised member mValidateOrigin

is false the right default value here?

Comment 9

[Malcolm Rowe]

(In reply to comment #8)
> is false the right default value here?

Good question - I don't know. The preference doesn't seem to be defaulted in any
existing .js files, or anywhere else. At the moment, it's probably random. Bug
13871 has some more details (and bug 13871 comment 45 says that it'll be off by
default, though that comment is over three years old now).

Comment 10

[Malcolm Rowe]

Comment on attachment 141341 [details] [diff] [review]
Fix unitialised member mValidateOrigin

> please ping me when this needs checking in.

bz: ping.

Comment 11

[Boris Zbarsky [:bzbarsky]]

> At the moment, it's probably random.

Actually, at the moment it's false.  See
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsWebShell.h#59

Still worth checking in, but that can probably be removed once we merge webshell
and docshell.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Checked in the mValidateOrigin change.