234128 - Composer->File menu has two menuitems (Publish and Page Setup) with the same hot key ''u".

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Sachin]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.6) Gecko/20040113

In the "File" menu of COMPOSER, both "Publish" and "Page Setup" menu items have
the same hot key "u". Pressing "u" selects "Publish" menu item and doesnot open
the "Page Setup" dialog box. 

Reproducible: Always
Steps to Reproduce:
1. Open Composer.
2. Select "File" menu. 
3. Press "u" to open "Page Setup" dialog box. 
Actual Results:  
"Publish" menu item gets focus.

Expected Results:  
"Page Setup" dialog box should be opened as it has "u" as its hotkey.

Comment 1

[Sachin]

The problem is not seen in MOZ 141. MOZ 141 did not have "Page Setup" menuitem
in "File" menu of Composer. It has been introduced in MOZ 1.6. Now both
"Publish" and "Page Setup" menuitems have the same hot key 'u'.  This problem
could be solved by changing the hot key of "Publish" menuitem to 'i'.  

Comment 2

[Sachin]

Attachment: Patch for Review

Comment 3

[timeless]

i think we should consider giving publish 'b' and giving publish as 'i'...

Comment 4

[[e-mail]]

"i" isn't a good access key... perhaps we could use "h" and bump Save As Charset
to use "v" instead?

Comment 5

[Mike Kaply [:mkaply]]

This has to go in today to be translated!

Comment 6

[timeless]

Re_vert is using v. I'd say drop "u" from Publish. people in a hurry can use the
command sequence.

Comment 7

[[e-mail]]

(In reply to comment #6)
>Re_vert is using v.
Ah, ok... I think "d" is still free...

Comment 8

[Sachin]

'i' is used as an access key for Edit->Properties menuitem of Address Book. It
is visible and doesnot look odd. I believe we can go ahead with 'i' as the
access key for File->Publish menuitem in the composer.

Comment 9

[timeless]

Attachment: musical chairs

"Publish": "u">"b"
"Publish As...": "b">"h"
"Save And Change Character Encoding": "h">"E"

"Send Page...": "g">"d"

This last one is future proofing.

Note that we still don't have a "Print Preview" menuitem.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 143502 [details] [diff] [review]
musical chairs

sr=dbaron if Daniel is ok with this

Comment 11

[timeless]

Comment on attachment 143502 [details] [diff] [review]
musical chairs

neil and i are both peers to editor, our decissions should be sufficient.
ignoring that, we did discuss this on #composer with glazou and he made it
clear that this was not even close to being on his list of concerns. he did not
express any concern at that time.

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

timeless is right here. I followed the thread and had no comment to make.
this implies moa=[e-mail]

Comment 13

[chris hofmann]

Comment on attachment 143502 [details] [diff] [review]
musical chairs

a=chofmann for 1.7b

Comment 14

[[e-mail]]

timeless checked in his patch, so marking fixed.