234546 - sending mail spins if we can't get access to a file attachment

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[David :Bienvenu]

If we get a file system error opening a file when trying to attach it during the
send process, we just spin forever w/o aborting the progress dialog. This is
because we blow off the error attaching the file. Fix upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[David :Bienvenu]

Comment on attachment 141551 [details] [diff] [review]
proposed fix

don't blow off error, and put up a meaningful error message.

Comment 3

[David :Bienvenu]

fixed on trunk.

Here's how I created the problem.

On one machine, using winzip, I added a file in my shared documents folder to a
zip archive called palmsync.xpi, using the file explorer context menu "add file
to zip archive"
On a second machine, I tried to attach the palmsync.xpi file, and then send the
message. It spun forever, because the .xpi file was locked.
Note that winzip was not open at the time. I don't know if the two machine setup
is needed to recreate this, but in general, we should handle failures to read
attachments.

Comment 4

[David :Bienvenu]

fixed on m4 branch

Comment 5

[David :Bienvenu]

fixed on trunk.