Closed Bug 234553 Opened 21 years ago Closed 20 years ago

incompletely downloaded imap messages can end up in offline store

Categories

(SeaMonkey :: MailNews: Backend, defect)

Product:
SeaMonkey
Component:
MailNews: Backend
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file)

potential fix
853 bytes, patch
mscott
: superreview+
Details | Diff | Splinter Review 
One user has reported getting imap messages in the offline store that don't have
some attachments downloaded correctly. The Mime parts on demand version of the
attachment "this part will be downloaded on demand" ends up in the offline
store. I don't know how this happened, exactly, but I suspect that there's some
sort of race condition or contention over
nsImapMailFolder::m_downloadMessageForOfflineUse. We set this appropriately in
nsImapService::DisplayMessage, but other code can come along and change this
before we actually get into the imap protocol code that fetches a message,
especially if urls get queued, etc.
Attached patch potential fix — — Splinter Review 
in the imap protocol code where we know we're fetching by parts, make sure that
the imap folder doesn't think we should save the msg for offline use.
Attachment #141554 - Flags: superreview?(mscott)
Attachment #141554 - Flags: superreview?(mscott) → superreview+
Summary: imcompletely downloaded imap messages can end up in offline store → incompletely downloaded imap messages can end up in offline store
fixed on branch
fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: