Closed
Bug 234688
Opened 21 years ago
Closed 21 years ago
Icons don't display in Firefox download manager
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
Details
(Keywords: fixed1.7)
Attachments
(1 file, 1 obsolete file)
|
1.17 KB,
patch
|
jhpedemonte
:
review+
mkaply
:
superreview+
mkaply
:
approval1.7+
|
Details | Diff | Splinter Review |
Come to find out, the icon decoder is supposed to support the ability to get
icons for extensions (like .zip or .exe)
This makes icons in the Firefox download manager work.
Patch coming.
|
Assignee | |
Comment 1•21 years ago
|
||
If we are asked to get the icon for an extension, we create a temporary file
and query its icon.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #141635 -
Flags: review?(grajaman)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #141635 -
Flags: review?(grajaman)
|
|
Assignee | |
Comment 3•21 years ago
|
||
We don't need a filename at all.
Just create a file called ".exe" or ".zip"
Attachment #141635 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #146271 -
Flags: review?(pedemont)
|
||
Updated•21 years ago
|
Attachment #146271 -
Flags: review?(pedemont) → review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Comment on attachment 146271 [details] [diff] [review]
A little better fix
sr=blizzard (platform specific), a=mkaply (OS/2 only)
Attachment #146271 -
Flags: superreview+
Attachment #146271 -
Flags: approval1.7+
|
|
Assignee | |
Comment 5•21 years ago
|
||
fixed on trunk and 1.7.
I just checked in this bustage fix:
- if (hIcon == NULLHANDLE) && (pszFileName[0] == '.')) {
+ if ((hIcon == NULLHANDLE) && (pszFileName[0] == '.')) {
(But only to the trunk. You should probably check that it's what you want
before landing on 1.7.)
You need to log in
before you can comment on or make changes to this bug.
Description
•