234724 - about:config fails miserably if you filter for string with uppercase chars

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

in function FilterPrefs()

  var substring = document.getElementById("textbox").value.toString();
note: this may contain uppercase chars
      if (gPrefArray[i].prefCol.toLowerCase().indexOf(substring) >= 0)
note: this can not possibly contain uppercase chars

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141653 [details] [diff] [review]
patch

sr=bzbarsky

Comment 3

[[e-mail]]

Comment on attachment 141653 [details] [diff] [review]
patch

>-  var substring = document.getElementById("textbox").value.toString();
What was I on when I wrote that? I probably wrote toString instead of
toLowerCase or something... take the toString out if you like.
>+  var substring = document.getElementById("textbox").value.toString().toLowerCase();

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in config.js;
/cvsroot/mozilla/xpfe/global/resources/content/config.js,v  <--  config.js
new revision: 1.12; previous revision: 1.11
done

Comment 5

[[e-mail]]

*** Bug 211041 has been marked as a duplicate of this bug. ***

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

forgot to remove .toString in my last checkin, did that now.