234982 - nsPrintEngine::ShowPrintErrorDialog() fails in many cases

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Roland Mainz]

nsPrintEngine::ShowPrintErrorDialog() fails in many cases where mozilla should
display one, therefore print errors may not be shown to the user.
This seems to affect mainly FireFox and ThunderBird, but sometimes even
Seamonkey "hides" those errors from the user.

Looking at the following code:
-- snip --
2305   nsCOMPtr<nsIWindowWatcher> wwatch =
do_GetService(NS_WINDOWWATCHER_CONTRACTID, &rv);
2306   if (NS_FAILED(rv))
2307     return;
2308 
2309   nsCOMPtr<nsIDOMWindow> active;
2310   wwatch->GetActiveWindow(getter_AddRefs(active));
2311 
2312   nsCOMPtr<nsIDOMWindowInternal> parent = do_QueryInterface(active);
2313   if (!parent)
2314     return;
-- snip --

|parent| is |nsnull| in this cases - and that's it. No error. And a confused
user.

Comment 1

[Roland Mainz]

Attachment: Patch for 2004-02-19-trunk

Comment 2

[Roland Mainz]

Comment on attachment 141792 [details] [diff] [review]
Patch for 2004-02-19-trunk

Requesting r=/sr= and checkin= to get rid of this mess...

Comment 3

[Roland Mainz]

rbs:
I remember I originally copied the print error dialog code from the code for
your MathML font warning dialog... is it possible that that dialog suffers from
the same problem ?

Comment 4

[rbs]

The MathML version has evolved from what it was originally. I have never heard
of a problem. On the contrary, I keep hearing of people wanting to get rid of it
-- as expected (by installing the fonts that the dialog complains about :-))

Comment 5

[Roland Mainz]

[e-mail] wrote:
> The MathML version has evolved from what it was originally. I have never heard
> of a problem.

BTW: Did you ever found a way to add HTML code as part of the dialog (for links
or tables) ?

> On the contrary, I keep hearing of people wanting to get rid of 
> it -- as expected (by installing the fonts that the dialog complains about 
> :-))

In this case I WANT that people get this dialog. There should be no way to avoid
it.... :)

Comment 6

[rbs]

>BTW: Did you ever found a way to add HTML code as part of the dialog (for links
>or tables) ?

I haven't bothered looking at this ever since. It is assigned to XUL folks as it
depended on things that are yet to happen. I don't recollect to have received
any bugmail that something has happened about them.

Comment 7

[Roland Mainz]

[e-mail] wrote:
> > BTW: Did you ever found a way to add HTML code as part of the dialog (for 
> > links or tables) ?
> I haven't bothered looking at this ever since. It is assigned to XUL folks as 
> it depended on things that are yet to happen.

I guess we need a new bug resolution "XUL-bug-noone-cares-about;ignore-bug" and
mark it as such. Mozilla's XUL implementation is just horrible - lots of stuff
like DOM, printing, BiDi etc. is just unuseable... ;-((

Comment 8

[Roland Mainz]

Patch checked-in by jst
(http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?module=MozillaTinderboxAll&branch=HEAD&cvsroot=/cvsroot&date=explicit&mindate=1077310500&maxdate=1077311160&who=jst%25mozilla.jstenback.com),
marking bug as FIXED.