Closed
Bug 235088
Opened 21 years ago
Closed 21 years ago
nsMessenger::GetString() callers leak memory
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
10.85 KB,
patch
|
darin.moz
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
Every caller of nsMessenger::GetString() leaks the returned string buffer :-)
Patch coming up.
|
Assignee | |
Comment 1•21 years ago
|
||
This'll make the string object returned by GetString() do the memory management
for us, just what nsAdoptingString was designed for! :-)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #141859 -
Flags: superreview?(sspitzer)
Attachment #141859 -
Flags: review?(sspitzer)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 141859 [details] [diff] [review]
Enter nsAdoptingString :-)
r=darin
Attachment #141859 -
Flags: review?(sspitzer) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #141859 -
Flags: superreview?(sspitzer) → superreview?(mscott)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 141859 [details] [diff] [review]
Enter nsAdoptingString :-)
very cool Johnny. I'll have to remember to try out your new nsAdoptingString
going forward.
Attachment #141859 -
Flags: superreview?(mscott) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•