235129 - crash while exporting bookmarks

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Žiga Sancin]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040220 Firefox/0.8.0+

If trying to export bookmarks (no matter which selected; e.g. the "main", "root"
bookmarks folder 'Bookmarks' or any other), the browser crashes. Similar to
#214966, but nobody has mentioned that Firefox would crash on export. Import
works fine in the latest build.

Reproducible: Always
Steps to Reproduce:
1. open bookmarks manager
2. click File > Export...

Actual Results:  
Browser crashes.

Expected Results:  
Save the exported bookmarks in the specified file (e.g. bookmarks.html).

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; pl-PL; rv:1.6) Gecko/20040206
Firefox/0.8

Comment 2

[edi]

(In reply to comment #0)

I followed you steps but it works fine for me. No crashes.
Even tried selecting and unselecting bookmarks links or folders.

I suggest you install Firefox in a clean directory and create a new profile, so
that you're sure it's the program and not, maybe, an outdated extension or a
theme...

Comment 3

[edi]

(addition to comment #2)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

Comment 4

[Žiga Sancin]

Yes, it looks like a regression... Works fine with Fx 0.8, but it doesn't work
with the latest (trunk) build.

Comment 5

[Jeff Walden [:Waldo]]

Confirming, tweaking summary, adding crash keyword.  I see this crash on the
20040220 build using WinXP.  I'm going to try to download a few older builds and
try to see if this is new as of that build or not.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040220
Firefox/0.8.0+

Comment 6

[Jeff Walden [:Waldo]]

Regressed between the 20040218 and 20040219 Win32 builds.  Exporting works fine
in the 18th build, but in the 19th it crashes.  Looking at the checkins, I have
no idea which was the guilty one.

Comment 7

[Žiga Sancin]

Hm, I think there must be something wrong with the checkins for Bug #68215. To
be more specific, there is probably something wrong with the checkin that
removed the "mTabContainer" code.

Comment 8

[basic]

Seeing this on linux:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040226 Firefox/0.8.0+

I think this is string related. stack trace below:

#0  0x40810006 in nanosleep () from /lib/i686/libc.so.6
#1  0xffffffa0 in ?? ()
#2  0x08062316 in ah_crap_handler(int) (signum=11) at nsSigHandlers.cpp:135
#3  0x41da50d6 in nsProfileLock::FatalSignalHandler(int) (signo=0)
    at /mnt/build/mozilla/profile/dirserviceprovider/src/nsProfileLock.cpp:209
#4  0x4022f4ec in __pthread_clock_settime () from /lib/i686/libpthread.so.0
#5  0x4078dca8 in __libc_sigaction () from /lib/i686/libc.so.6
#6  0x401b0a01 in nsSubstring::Equals(unsigned short const*, nsStringComparator
const&) const (this=0xbfffbfac, data=0xbfffc030, comp=@0xbfffc358)
    at nsTSubstring.cpp:540
#7  0x42add6a0 in nsBookmarksService::exportBookmarks(nsISupportsArray*) (
    this=0x84c8650, aArguments=0x91e6d38)
    at
/mnt/build/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp:3888
#8  0x42addace in nsBookmarksService::DoCommand(nsISupportsArray*,
nsIRDFResource*, nsISupportsArray*) (this=0x84c8650, aSources=0x9332f50,
    aCommand=0x84b2d38, aArguments=0x91e6d38)
    at
/mnt/build/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp:3959
#9  0x401a6f2d in XPTC_InvokeByIndex () from ./libxpcom.so
#10 0x40b49019 in XPCWrappedNative::CallMethod(XPCCallContext&,
XPCWrappedNative::CallMode) (ccx=@0xbfffc70c, mode=CALL_METHOD)
---Type <return> to continue, or q <return> to quit---
    at /mnt/build/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2026#11
0x40b51f00 in XPC_WN_CallMethod(JSContext*, JSObject*, unsigned, long*, long*)
(cx=0x8fd7738, obj=0x8ec5668, argc=3, argv=0x86560f8, vp=0xbfffc83c)
    at /mnt/build/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1287
#12 0x40052714 in js_Invoke (cx=0x8fd7738, argc=3, flags=0)
    at /mnt/build/mozilla/js/src/jsinterp.c:941
#13 0x400589da in js_Interpret (cx=0x8fd7738, result=0xbfffcb68)
    at /mnt/build/mozilla/js/src/jsinterp.c:2962
#14 0x400527dc in js_Invoke (cx=0x8fd7738, argc=1, flags=2)
    at /mnt/build/mozilla/js/src/jsinterp.c:958
#15 0x40b4223a in nsXPCWrappedJSClass::CallMethod(nsXPCWrappedJS*, unsigned
short, nsXPTMethodInfo const*, nsXPTCMiniVariant*) (this=0x8722758,
    wrapper=0x902d5e0, methodIndex=5, info=0x822d6d0, nativeParams=0xbfffcf7c)
    at /mnt/build/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1336
#16 0x40b3c77f in nsXPCWrappedJS::CallMethod(unsigned short, nsXPTMethodInfo
const*, nsXPTCMiniVariant*) (this=0x902d5e0, methodIndex=5, info=0x822d6d0,
    params=0xbfffcf7c)
    at /mnt/build/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp:449
#17 0x401a71a4 in PrepareAndDispatch (methodIndex=5, self=0x902d5e0,
    args=0x822d6d0)

Comment 9

[basic]

Attachment: patch (firefox)

add a null check. New string doesn't check for nulls

Comment 10

[basic]

Attachment: patch (seamonkey)

same patch for seamonkey

Comment 11

[basic]

Attachment: patch (firefox)

oops forgot ()

Comment 12

[basic]

Attachment: patch (seamonkey)

same

Comment 13

[Christian Reis]

Those are some pretty long lines there...

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

fixed

Comment 15

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 16

[YaoMingWang]

[Verification day-20140521]
Reproduced with Latest Nightly from 2014-05-21 with STR from comment 0.
Verified as fixed on latest Nightly 32.0a1(Build Id: 20140520030202) on Ubuntu 14.04 x64
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0

Comment 17

[YaoMingWang]

The above comment is wrong,sorry for that. I couldn't find older builds to reproduce this,but with latest Nighty it works as expected, this bug is not present.
###################################################################################################
PS:I'm new here,sorry for that